/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add error codes for malformed/bad JSON in /login #608

Merged
merged 2 commits into from Feb 26, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gergelypolonkai @matrixbot @dbkr
@gergelypolonkai

gergelypolonkai commented Feb 26, 2016

Malformed/bad JSON data caused an M_UNKNOWN to be sent for the client instead of NOT_JSON/BAD_JSON.
Add error codes for malformed/bad JSON in /login 
Signed-off-by: Gergely Polonkai <gergely@polonkaieu>
a537747
@matrixbot

matrixbot commented Feb 26, 2016

Can one of the admins verify this patch?
@dbkr
Member

dbkr commented Feb 26, 2016

matrixbot: ok to test
@dbkr
Member

dbkr commented Feb 26, 2016

Needs more line breaks to appease the PEP8 dragon, but otherwise lgtm.

So you'd want:

raise SynapseError(
    400, "Content must be a JSON object.", errcode=Codes.BAD_JSON
)
@gergelypolonkai

gergelypolonkai commented Feb 26, 2016

There you go, PEP8 dragon.

dbkr added a commit that referenced this pull request Feb 26, 2016

@dbkr
Merge pull request #608 from gergelypolonkai/syn-638 
Add error codes for malformed/bad JSON in /login
9329cd5

@dbkr dbkr merged commit 9329cd5 into matrix-org:develop Feb 26, 2016
1 check passed

1 check passed

default Build finished. 367 tests run, 0 skipped, 0 failed.
Details

@gergelypolonkai gergelypolonkai deleted the gergelypolonkai:syn-638 branch Mar 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment