Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support for changing the actions for default rules #609

Merged
merged 1 commit into from Feb 26, 2016

Conversation

Projects
None yet
2 participants
Contributor

NegativeMjark commented Feb 26, 2016

See matrix-org/matrix-doc#283

Works by adding dummy rules to the push rules table with a negative priority class and then using those rules to clobber the default rule actions when adding the default rules in list_with_base_rules

Member

dbkr commented Feb 26, 2016

Yep, as you say IRL, may want to strip out any remaining rules with prio class -1 or otherwise handle this, although of course it's perfectly safe until we remove a default rule! Probably should do the check now though rather than leaving a heffalump trap for someone. Otherwise lgtm.

@dbkr dbkr assigned NegativeMjark and unassigned dbkr Feb 26, 2016

Contributor

NegativeMjark commented Feb 26, 2016

I've removed all the rules with negative prio class, b3fb790

Member

dbkr commented Feb 26, 2016

lgtm, merge it! :)

Add support for changing the actions for default rules
See matrix-org/matrix-doc#283

Works by adding dummy rules to the push rules table with a negative priority class and then using those rules to clobber the default rule actions when adding the default rules in ``list_with_base_rules``

NegativeMjark added a commit that referenced this pull request Feb 26, 2016

Merge pull request #609 from matrix-org/markjh/change_action
Add support for changing the actions for default rules

See matrix-org/matrix-doc#283

Works by adding dummy rules to the push rules table with a negative priority class and then using those rules to clobber the default rule actions when adding the default rules in ``list_with_base_rules``

@NegativeMjark NegativeMjark merged commit 4bf13a8 into develop Feb 26, 2016

1 check was pending

default Build triggered. sha1 is merged.
Details

@richvdh richvdh deleted the markjh/change_action branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment