Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add support for changing the actions for default rules #609
Conversation
NegativeMjark
assigned
dbkr
Feb 26, 2016
|
Yep, as you say IRL, may want to strip out any remaining rules with prio class -1 or otherwise handle this, although of course it's perfectly safe until we remove a default rule! Probably should do the check now though rather than leaving a heffalump trap for someone. Otherwise lgtm. |
dbkr
assigned
NegativeMjark
and unassigned
dbkr
Feb 26, 2016
|
I've removed all the rules with negative prio class, b3fb790 |
|
lgtm, merge it! :) |
NegativeMjark
added a commit
that referenced
this pull request
Feb 26, 2016
NegativeMjark
merged commit 4bf13a8
into
develop
Feb 26, 2016
1 check was pending
default
Build triggered. sha1 is merged.
Details
richvdh
deleted the
markjh/change_action
branch
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
NegativeMjark commentedFeb 26, 2016
See matrix-org/matrix-doc#283
Works by adding dummy rules to the push rules table with a negative priority class and then using those rules to clobber the default rule actions when adding the default rules in
list_with_base_rules