/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

handlers/register: make sure another user id is generated when a collision occurs #610

Merged
merged 1 commit into from Mar 4, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Rugvip @matrixbot @erikjohnston
@Rugvip
Contributor

Rugvip commented Feb 29, 2016

Fixes a race condition that would cause user registration to fail with

twisted.python.failure.Failure sqlite3.IntegrityError: UNIQUE constraint failed: profiles.user_id

without returning an error to the client, but just setting the user id and access token to null.
@Rugvip
handlers/register: make sure another user id is generated when a coll… 
…ision occurs

Signed-off-by: Patrik Oldsberg <patrik.oldsberg@ericsson.com>

Some checks were not successful

1 errored and 1 successful checks
@matrixbot
Synapse — Build #6260 failed in 5 min 19 sec
Details
@matrixbot
default — Build finished. 371 tests run, 0 skipped, 0 failed.
Details
9c48f1e
@matrixbot

matrixbot commented Feb 29, 2016

Can one of the admins verify this patch?
@erikjohnston
Owner

erikjohnston commented Feb 29, 2016

@matrixbot ok to test

erikjohnston added a commit that referenced this pull request Mar 4, 2016

@erikjohnston
Merge pull request #610 from Rugvip/unique-user 
handlers/register: make sure another user id is generated when a collision occurs

All checks have passed

4 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #50 origin/develop succeeded in 27 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #50 origin/develop succeeded in 4 min 57 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #50 origin/develop succeeded in 4 min 10 sec
Details
@matrixbot
Unit Tests (Commit) — Build #95 origin/develop succeeded in 1 min 7 sec
Details
ce82b9e

@erikjohnston erikjohnston merged commit ce82b9e into matrix-org:develop Mar 4, 2016
1 of 2 checks passed

1 of 2 checks passed

Synapse Build #6260 failed in 5 min 19 sec
Details
default Build finished. 371 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment