Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill off half-implemented password-reset via sms #6101

Merged
merged 2 commits into from Sep 26, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Sep 24, 2019

Doing a password reset via SMS has never worked, and in any case is a silly
idea because msisdn recycling is a thing.

See also matrix-org/matrix-doc#2303.

(I suggest we hold off landing this until after we've cut a release branch.)

Doing a password reset via SMS has never worked, and in any case is a silly
idea because msisdn recycling is a thing.
@richvdh richvdh added this to In progress in Homeserver Task Board via automation Sep 24, 2019
Copy link
Contributor

neilisfragile left a comment

LGTM

@richvdh richvdh moved this from In progress to Review in Homeserver Task Board Sep 26, 2019
@richvdh richvdh self-assigned this Sep 26, 2019
@richvdh richvdh merged commit 54569c7 into develop Sep 26, 2019
19 of 20 checks passed
19 of 20 checks passed
coverage/coveralls Coverage decreased (-50.3%) to 17.585%
Details
buildkite/synapse Build #4563 passed (18 minutes, 46 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 20 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 17 seconds)
Details
buildkite/synapse/isort Passed (19 seconds)
Details
buildkite/synapse/mypy Passed (47 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (18 seconds)
Details
buildkite/synapse/packaging Passed (21 seconds)
Details
buildkite/synapse/pipeline Passed (8 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (11 minutes, 29 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (4 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (4 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (4 minutes, 23 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (9 minutes, 20 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (8 minutes, 52 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (8 minutes, 57 seconds)
Details
buildkite/synapse/trigger-webhook Passed (7 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Sep 26, 2019
@richvdh richvdh deleted the rav/kill_msisdn_password_reset branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.