Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some helpful opentracing tags and remove get_user_by_req span #6108

Merged
merged 5 commits into from Sep 27, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Sep 25, 2019

Commits should be independently reviewable and explain whats going on

We don't actually care about what happens in `get_user_by_req` and
having it as a separate span means that the entity tag isn't added to
the servlet spans, making it harder to search.
This will make it easier to search for sending event requests.
@erikjohnston erikjohnston changed the title Add some helpful opentracing spans Add some helpful opentracing tags Sep 25, 2019
@erikjohnston erikjohnston changed the title Add some helpful opentracing tags Add some helpful opentracing tags and remove get_user_by_req span Sep 25, 2019
@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Sep 25, 2019
Copy link
Member

richvdh left a comment

lgtm

@erikjohnston erikjohnston merged commit 67ee18d into develop Sep 27, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #4583 passed (20 minutes, 1 second)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 10 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 15 seconds)
Details
buildkite/synapse/isort Passed (19 seconds)
Details
buildkite/synapse/mypy Passed (21 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (17 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (8 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (11 minutes, 55 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (4 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (6 minutes, 48 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (4 minutes, 17 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (11 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 42 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (4 minutes, 13 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (9 minutes, 33 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (9 minutes, 8 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (8 minutes, 39 seconds)
Details
buildkite/synapse/trigger-webhook Passed (8 seconds)
Details
coverage/coveralls Coverage increased (+0.02%) to 67.986%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.