Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cas: support setting display name #6114

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@tharvik
Copy link
Contributor

tharvik commented Sep 26, 2019

Now, the CAS server can return an attribute stating what's the desired displayname, instead of using the username directly.

btw, one nice config block for cas' attributes would be

cas_config:
    server_url: "https://cas-server.com"
    service_url: "https://homeserver.domain.com:8448"
    attributes:
        display_name: name
        required:
            name: value

but that would break existing config.

@richvdh richvdh requested a review from matrix-org/synapse-core Oct 3, 2019
Copy link
Member

erikjohnston left a comment

This looks good to me other than the code styling problem. My ask @richvdh to double check this makes sense from an SSO/CAS PoV

synapse/rest/client/v1/login.py Outdated Show resolved Hide resolved
@richvdh richvdh self-requested a review Oct 9, 2019
Copy link
Member

richvdh left a comment

looks generally good, a couple of comments though

synapse/rest/client/v1/login.py Outdated Show resolved Hide resolved
synapse/config/cas.py Outdated Show resolved Hide resolved
@tharvik tharvik force-pushed the c4dt:cas_set-displayname branch from cb94cb8 to 75ad597 Oct 11, 2019
Signed-off-by: Valérian Rousset <tharvik@users.noreply.github.com>
@richvdh richvdh self-requested a review Oct 11, 2019
Copy link
Member

richvdh left a comment

looks good to me other than a tweak to the changelog wording!

changelog.d/6114.feature Outdated Show resolved Hide resolved
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Copy link
Member

richvdh left a comment

thank you for the contribution!

@richvdh richvdh merged commit be9b55e into matrix-org:develop Oct 11, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4927 passed (18 minutes, 53 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 33 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 27 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (24 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 14 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (5 minutes, 30 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 16 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (5 minutes, 57 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (16 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (16 minutes, 38 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 53 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 20 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (15 minutes, 9 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (15 minutes, 13 seconds)
Details
@tharvik tharvik deleted the c4dt:cas_set-displayname branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.