Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject pending invites on deactivation #6125

Merged
merged 10 commits into from Sep 27, 2019

Conversation

@babolivier
Copy link
Member

babolivier commented Sep 27, 2019

When deactivating a user, reject all of their pending invite, so that they don't appear as "invited" in rooms anymore.

babolivier added 4 commits Sep 27, 2019
@babolivier babolivier requested a review from matrix-org/synapse-core Sep 27, 2019
babolivier added 2 commits Sep 27, 2019
ok
Copy link
Member

anoadragon453 left a comment

lgtm otherwise

changelog.d/6125.feature Outdated Show resolved Hide resolved
synapse/handlers/deactivate_account.py Outdated Show resolved Hide resolved
synapse/handlers/deactivate_account.py Outdated Show resolved Hide resolved
synapse/handlers/deactivate_account.py Outdated Show resolved Hide resolved
synapse/handlers/deactivate_account.py Outdated Show resolved Hide resolved
synapse/handlers/deactivate_account.py Show resolved Hide resolved
synapse/handlers/deactivate_account.py Show resolved Hide resolved
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
babolivier and others added 3 commits Sep 27, 2019
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
@babolivier

This comment has been minimized.

Copy link
Member Author

babolivier commented Sep 27, 2019

The review dismissal was a config error on the repo (see convo), therefore I'm merging this.

@babolivier babolivier merged commit 8f90b0e into develop Sep 27, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4659 passed (18 minutes, 27 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 26 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 21 seconds)
Details
buildkite/synapse/isort Passed (30 seconds)
Details
buildkite/synapse/mypy Passed (36 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (28 seconds)
Details
buildkite/synapse/packaging Passed (19 seconds)
Details
buildkite/synapse/pipeline Passed (9 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (16 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (4 minutes, 35 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (6 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (4 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (16 minutes, 30 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (16 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (4 minutes, 17 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (9 minutes, 36 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (8 minutes, 35 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (8 minutes, 29 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.