Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HomeserverConfig so it can be typechecked #6137

Merged
merged 34 commits into from Oct 10, 2019

Conversation

@hawkowl
Copy link
Contributor

hawkowl commented Sep 30, 2019

This means that static typing can now functionally be used, if we define type stubs/mypy can infer things

hawkowl added 23 commits Sep 6, 2019
…synapse into hawkowl/config-cleanup
fix
@hawkowl hawkowl added this to In progress in Homeserver Task Board via automation Oct 2, 2019
hawkowl added 6 commits Oct 2, 2019
@hawkowl hawkowl requested a review from matrix-org/synapse-core Oct 3, 2019
@hawkowl hawkowl marked this pull request as ready for review Oct 3, 2019
@hawkowl hawkowl moved this from In progress to Review in Homeserver Task Board Oct 3, 2019
Copy link
Member

richvdh left a comment

looks good, but a few questions

@@ -52,3 +48,15 @@ ignore_missing_imports = True

[mypy-signedjson.*]
ignore_missing_imports = True

[mypy-prometheus_client.*]

This comment has been minimized.

Copy link
@richvdh

richvdh Oct 7, 2019

Member

why are we adding this sort of thing?

This comment has been minimized.

Copy link
@hawkowl

hawkowl Oct 7, 2019

Author Contributor

because we don't have type stubs for these modules, so therefore we don't want to typecheck them. We don't want to ignore missing imports completely, just on dependencies without type hints.

This comment has been minimized.

Copy link
@richvdh

richvdh Oct 9, 2019

Member

ok, but it just doesn't seem related to the subject of the PR and the text of the changelog.

I guess it's necesary because of https://github.com/matrix-org/synapse/pull/6137/files#diff-b91f3d5bd63fcd17221b267e851608e8R169?

synapse/config/_base.py Outdated Show resolved Hide resolved
synapse/config/_base.py Outdated Show resolved Hide resolved
synapse/config/_base.py Outdated Show resolved Hide resolved
synapse/config/_base.py Show resolved Hide resolved
synapse/config/_base.py Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
hawkowl and others added 5 commits Oct 7, 2019
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@hawkowl hawkowl requested review from richvdh and matrix-org/synapse-core and removed request for richvdh Oct 8, 2019
@richvdh
richvdh approved these changes Oct 9, 2019
Copy link
Member

richvdh left a comment

lgtm.

@hawkowl hawkowl merged commit f743108 into develop Oct 10, 2019
16 of 18 checks passed
16 of 18 checks passed
buildkite/synapse Build #4846 failed (36 minutes, 33 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Failed (exit status 1)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 37 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 28 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/mypy Passed (22 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 20 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (5 minutes, 33 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 34 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (16 minutes, 25 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 23 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 56 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 36 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Oct 10, 2019
@hawkowl hawkowl deleted the hawkowl/config-cleanup branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.