Skip to content

/synapse

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log responder we are using. #6139

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@michaelkaye
Copy link
Contributor

michaelkaye commented Sep 30, 2019 •
edited

This prevents us logging "Responding to media request with responder %s".

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off
michaelkaye added 2 commits Sep 30, 2019
@michaelkaye
Log responder we are using.
Loading status checks…
348a043 
This prevents us logging "Responding to media request with responder %s".
@michaelkaye
Ensure we log the responder we're using
Loading status checks…
db0d144
@anoadragon453
anoadragon453 approved these changes Oct 7, 2019
View changes
Copy link
Member

anoadragon453 left a comment

Whoops, good catch, thanks!
@anoadragon453 anoadragon453 merged commit dc795ba into develop Oct 7, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4673 passed (31 minutes, 2 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 10 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 15 seconds)
Details
buildkite/synapse/isort Passed (21 seconds)
Details
buildkite/synapse/mypy Passed (46 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (17 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (8 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (4 minutes, 23 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (6 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (4 minutes, 23 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (16 minutes, 48 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (4 minutes, 26 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (10 minutes, 1 second)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (9 minutes, 31 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (12 minutes, 15 seconds)
Details
@anoadragon453 anoadragon453 deleted the michaelkaye/fix_logging_typo branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@michaelkaye @anoadragon453
You can’t perform that action at this time.