Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up some typechecking #6150

Merged
merged 2 commits into from Oct 2, 2019

Conversation

@hawkowl
Copy link
Contributor

hawkowl commented Oct 2, 2019

Splitting some stuff out from the other PR that now fails when we properly typecheck synapse/config/...

hawkowl added 2 commits Oct 2, 2019
@hawkowl hawkowl requested a review from matrix-org/synapse-core Oct 2, 2019
@hawkowl hawkowl added this to In progress in Homeserver Task Board via automation Oct 2, 2019
@hawkowl hawkowl moved this from In progress to Review in Homeserver Task Board Oct 2, 2019
@hawkowl hawkowl merged commit 864f144 into develop Oct 2, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4702 passed (20 minutes, 5 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 38 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 45 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/mypy Passed (45 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (19 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (16 minutes, 57 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (15 minutes, 10 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 10 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 7 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 29 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (11 minutes, 56 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 10 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (10 minutes, 37 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Oct 2, 2019
@hawkowl hawkowl deleted the hawkowl/type-checking-madness branch Oct 2, 2019
@kyrias

This comment has been minimized.

Copy link
Contributor

kyrias commented Nov 3, 2019

Since synapse doesn't seem to use any of the "experimental" things that haven't yet been added to the typing module, could this dependency be made conditional on the python version instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.