Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public room list pagination. #6152

Merged
merged 2 commits into from Oct 2, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Oct 2, 2019

We incorrectly used room_id as to bound the result set, even though we
order by joined_members, room_id, leading to incorrect results after
pagination.

erikjohnston added 2 commits Oct 2, 2019
We incorrectly used `room_id` as to bound the result set, even though we
order by `joined_members, room_id`, leading to incorrect results after
pagination.
@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 2, 2019
Copy link
Member

babolivier left a comment

lgtm

@erikjohnston erikjohnston merged commit 824df3e into develop Oct 2, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4713 passed (20 minutes, 1 second)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 37 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 40 seconds)
Details
buildkite/synapse/isort Passed (18 seconds)
Details
buildkite/synapse/mypy Passed (23 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (19 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 1 second)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (16 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 4 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (16 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 8 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (12 minutes, 45 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (10 minutes, 23 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (10 minutes, 16 seconds)
Details
@erikjohnston erikjohnston added this to In progress in Homeserver Task Board via automation Oct 2, 2019
@erikjohnston erikjohnston moved this from In progress to Done in Homeserver Task Board Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.