Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not showing non-federatable rooms to remote room list queries #6153

Merged
merged 3 commits into from Oct 2, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Oct 2, 2019

This was broken when we changed the room list query.

Based on #6152. Broke in #6019.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 2, 2019
@erikjohnston erikjohnston changed the title Erikj/fix room list non federatable Fix not showing non-federatable rooms to remote room list queries Oct 2, 2019
@erikjohnston erikjohnston added this to In progress in Homeserver Task Board via automation Oct 2, 2019
@erikjohnston erikjohnston moved this from In progress to Review in Homeserver Task Board Oct 2, 2019
…x_room_list_non_federatable
@richvdh
richvdh approved these changes Oct 2, 2019
Copy link
Member

richvdh left a comment

lgtm. tests would be nice.

@erikjohnston erikjohnston merged commit 22a6ffd into develop Oct 2, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4717 passed (19 minutes, 33 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 28 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 33 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (23 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (17 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (5 minutes, 46 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 1 second)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 2 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (15 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 49 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 40 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 54 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (12 minutes, 20 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.