Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appservice room list pagination #6154

Merged
merged 2 commits into from Oct 2, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Oct 2, 2019

We need to add to query_args in the same order as the various clauses appear in the SQL.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 2, 2019
@richvdh
richvdh approved these changes Oct 2, 2019
Copy link
Member

richvdh left a comment

lgtm. tests would be nice.

@erikjohnston erikjohnston merged commit dca7e32 into develop Oct 2, 2019
16 of 18 checks passed
16 of 18 checks passed
buildkite/synapse Build #4719 started
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Started...
Details
buildkite/synapse/check-sample-config Passed (1 minute, 33 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 46 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/mypy Passed (24 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (19 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (5 minutes, 33 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 28 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 1 second)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (11 minutes, 1 second)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 17 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (11 minutes, 34 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.