Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributer docs for using the provided linters script #6164

Merged
merged 5 commits into from Nov 1, 2019

Conversation

@jaywink
Copy link
Member

jaywink commented Oct 3, 2019

Add also to the pull request template to avoid build failures due
to people not knowing that linters need running.

Add lint dependencies black, flake8 and isort.
These are required when running the lint.sh dev scripts.

jaywink added 2 commits Oct 3, 2019
These are required when running the `lint.sh` dev scripts.

Signed-off-by: Jason Robinson <jasonr@matrix.org>
Add also to the pull request template to avoid build failures due
to people not knowing that linters need running.

Signed-off-by: Jason Robinson <jasonr@matrix.org>
@jaywink jaywink requested a review from matrix-org/synapse-core Oct 3, 2019
Copy link
Member

anoadragon453 left a comment

Thank you for this! Just some small changes.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
synapse/python_dependencies.py Outdated Show resolved Hide resolved
jaywink and others added 3 commits Oct 22, 2019
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Signed-off-by: Jason Robinson <jasonr@matrix.org>
@jaywink jaywink requested a review from anoadragon453 Oct 22, 2019
@jaywink

This comment has been minimized.

Copy link
Member Author

jaywink commented Oct 22, 2019

Comments addressed!

@hawkowl
hawkowl approved these changes Nov 1, 2019
@hawkowl hawkowl merged commit 67a6591 into develop Nov 1, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #5050 passed (33 minutes, 38 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 35 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 46 seconds)
Details
buildkite/synapse/isort Passed (19 seconds)
Details
buildkite/synapse/mypy Passed (54 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (8 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (5 minutes, 56 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (5 minutes, 12 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 1 second)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 28 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 21 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (14 minutes, 11 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 47 seconds)
Details
@hawkowl hawkowl deleted the jaywink/linters-doc branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.