Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /federation/v1/state for recent room versions #6170

Merged
merged 4 commits into from Oct 8, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Oct 5, 2019

Turns out this endpoint was completely broken for v3 rooms. Hopefully this
re-signing code is irrelevant nowadays anyway.

Turns out this endpoint was completely broken for v3 rooms. Hopefully this
re-signing code is irrelevant nowadays anyway.
@richvdh richvdh force-pushed the rav/fix_get_state branch from 59c9ccc to c4956d1 Oct 5, 2019
@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Oct 5, 2019

@richvdh richvdh added this to In progress in Homeserver Task Board via automation Oct 5, 2019
@richvdh richvdh moved this from In progress to Review in Homeserver Task Board Oct 5, 2019
@richvdh richvdh requested a review from matrix-org/synapse-core Oct 5, 2019
@anoadragon453

This comment has been minimized.

Copy link
Member

anoadragon453 commented Oct 7, 2019

This PR is consistently failing on the Name/topic keys are correct. Perhaps your branch needs to be merged forwards?

Or perhaps it's just the flaky public rooms directory...

@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Oct 7, 2019

the latter, I think

@anoadragon453

This comment has been minimized.

Copy link
Member

anoadragon453 commented Oct 7, 2019

* tries to run the tests again

@richvdh richvdh force-pushed the rav/fix_get_state branch 2 times, most recently from 97eda27 to f4b41f7 Oct 7, 2019
This reverts commit f4b41f7.
@hawkowl
hawkowl approved these changes Oct 7, 2019
@hawkowl hawkowl merged commit b94a401 into develop Oct 8, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4823 passed (18 minutes, 53 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 27 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 27 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/mypy Passed (26 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (16 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (5 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 4 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (5 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (16 minutes, 44 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 4 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 5 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (11 minutes, 13 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (11 minutes, 46 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (10 minutes, 20 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Oct 8, 2019
@hawkowl hawkowl deleted the rav/fix_get_state branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.