Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out backgroung updates #6178

Merged
merged 14 commits into from Oct 9, 2019

Conversation

@babolivier
Copy link
Member

babolivier commented Oct 7, 2019

Part of the ongoing work on synapse_port_db, factor out the background updates handlers and registration to dedicated stores so that a script can instantiate a subset of the DataStore to only run them and not the whole thing, which would start other background processes we might not want to run.

This PR doesn't include factoring out the StatsStore, because doing so on this class is not trivial, and it doesn't register any looping call or background process (apart from background updates).

@babolivier babolivier requested a review from matrix-org/synapse-core Oct 7, 2019
@erikjohnston erikjohnston added this to In progress in Homeserver Task Board via automation Oct 8, 2019
@erikjohnston erikjohnston moved this from In progress to Review in Homeserver Task Board Oct 8, 2019
changelog.d/6178.bugfix Show resolved Hide resolved
synapse/storage/client_ips.py Outdated Show resolved Hide resolved
synapse/storage/client_ips.py Outdated Show resolved Hide resolved
synapse/storage/registration.py Outdated Show resolved Hide resolved
synapse/storage/state.py Show resolved Hide resolved
babolivier added 3 commits Oct 8, 2019
@babolivier babolivier requested a review from matrix-org/synapse-core Oct 8, 2019
@babolivier babolivier merged commit 59d6290 into develop Oct 9, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4849 passed (19 minutes, 58 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 29 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 45 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/mypy Passed (46 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (42 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 20 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (5 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 49 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (5 minutes, 25 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 48 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 56 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 12 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 22 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 14 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (12 minutes, 5 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Oct 9, 2019
@hawkowl hawkowl deleted the babolivier/factor_out_bg_updates branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.