Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused public room list timeout param #6179

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@anoadragon453
Copy link
Member

anoadragon453 commented Oct 7, 2019

Remove timeout param from _get_public_room_list that didn't do anything.

I believe this was a quick fix to fix the badly-performing public rooms list, but hopefully that should've been fundamentally fixed at this point :)

@anoadragon453 anoadragon453 self-assigned this Oct 7, 2019
@anoadragon453 anoadragon453 added this to In progress in Homeserver Task Board via automation Oct 7, 2019
@hawkowl hawkowl self-requested a review Oct 8, 2019
@hawkowl
hawkowl approved these changes Oct 8, 2019
@hawkowl hawkowl merged commit ea7d938 into develop Oct 8, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4832 passed (20 minutes, 12 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 25 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 39 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (22 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (27 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (5 minutes, 29 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes, 31 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (16 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 7 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 42 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (10 minutes, 53 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (11 minutes, 58 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (10 minutes)
Details
Homeserver Task Board automation moved this from In progress to Done Oct 8, 2019
@hawkowl hawkowl deleted the anoa/remove_timeout branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.