/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Stop using checkpw as it seems to have vanished from bcrypt. #619

Merged
merged 1 commit into from Mar 3, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@dbkr @erikjohnston @richvdh
@dbkr
Member

dbkr commented Mar 2, 2016

Use bcrypt.hashpw(password, hashed) == hashed as per the bcrypt README.
@dbkr
Stop using checkpw as it seems to have vanished from bcrypt. Use `bcr… 
…ypt.hashpw(password, hashed) == hashed` as per the bcrypt README.

Some checks were not successful

5 errored, 1 failing, 1 pending, and 4 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #37 origin/dbkr/dont_use_checkpw failed in 2.2 sec
Details
@matrixbot
Synapse — Build #6274 origin/dbkr/dont_use_checkpw failed in 5 min 21 sec
Details
@matrixbot
SynapseUnittestsCommit — Build #78 origin/dbkr/dont_use_checkpw failed in 2.5 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #37 origin/dbkr/dont_use_checkpw failed in 2.3 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #37 origin/dbkr/dont_use_checkpw failed in 2.1 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Tox (Merged PR) — Build triggered. sha1 is merged.
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
@matrixbot
default — Build finished.
Details
ff8b871

@dbkr dbkr assigned erikjohnston Mar 2, 2016

@erikjohnston
Owner

erikjohnston commented Mar 3, 2016

@matrixbot retest this please
@erikjohnston
Owner

erikjohnston commented Mar 3, 2016

@dbkr Looks like there is a PEP8 violation
@erikjohnston
Owner

erikjohnston commented Mar 3, 2016

Huh, or not.
@erikjohnston
Owner

erikjohnston commented Mar 3, 2016

retest this please
@erikjohnston
Owner

erikjohnston commented Mar 3, 2016

retest this please
@richvdh
Member

richvdh commented Mar 3, 2016

retest this please
@richvdh
Member

richvdh commented Mar 3, 2016

retest this please
@richvdh
Member

richvdh commented Mar 3, 2016

retest this please
@richvdh
Member

richvdh commented Mar 3, 2016

retest this please
@richvdh
Member

richvdh commented Mar 3, 2016

retest this please
@richvdh
Member

richvdh commented Mar 3, 2016

retest this please

erikjohnston added a commit that referenced this pull request Mar 3, 2016

@erikjohnston
Merge pull request #619 from matrix-org/dbkr/dont_use_checkpw 
Stop using checkpw as it seems to have vanished from bcrypt.
5c90451

@erikjohnston erikjohnston merged commit 5c90451 into develop Mar 3, 2016
0 of 7 checks passed

0 of 7 checks passed

Synapse Build #6274 origin/dbkr/dont_use_checkpw failed in 5 min 21 sec
Details
Flake8 + Packaging (Merged PR) Build triggered. sha1 is merged.
Details
Sytest Postgres (Merged PR) Build triggered. sha1 is merged.
Details
Sytest SQLite (Merged PR) Build triggered. sha1 is merged.
Details
Tox (Merged PR) Build triggered. sha1 is merged.
Details
Unit Tests (Merged PR) Build triggered. sha1 is merged.
Details
default Build triggered. sha1 is merged.
Details

@richvdh richvdh deleted the dbkr/dont_use_checkpw branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment