Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make storage layer in charge of interpreting the device key data #6193

Merged
merged 4 commits into from Oct 11, 2019

Conversation

@uhoreg
Copy link
Member

uhoreg commented Oct 10, 2019

as a result of: #5726 (comment)

@uhoreg uhoreg requested a review from matrix-org/synapse-core Oct 11, 2019
@@ -40,7 +40,7 @@ def get_e2e_device_keys(
This option only takes effect if include_all_devices is true.
Returns:
Dict mapping from user-id to dict mapping from device_id to
dict containing "key_json", "device_display_name".
key data.

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Oct 11, 2019

Member

Could you give a little bit more detail on the format here please?

@uhoreg uhoreg merged commit 06fc66c into develop Oct 11, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4942 passed (22 minutes, 18 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 32 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 28 seconds)
Details
buildkite/synapse/isort Passed (28 seconds)
Details
buildkite/synapse/mypy Passed (54 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (23 seconds)
Details
buildkite/synapse/packaging Passed (34 seconds)
Details
buildkite/synapse/pipeline Passed (19 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (9 minutes, 50 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (11 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (9 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 38 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (11 minutes, 44 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (17 minutes, 18 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (16 minutes, 40 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (16 minutes, 52 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.