Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace non-JSON APIs, /media, /key etc #6195

Merged
merged 2 commits into from Oct 11, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Oct 11, 2019

This should reduce the number of There was no active span when trying to set a tag. Did you forget to start one or did a context slip? errors

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 11, 2019
@erikjohnston erikjohnston force-pushed the erikj/opentracing_preview_url branch from 108386c to 4d4ac5d Oct 11, 2019
@erikjohnston erikjohnston force-pushed the erikj/opentracing_preview_url branch from 4d4ac5d to de3a176 Oct 11, 2019
Copy link
Member

richvdh left a comment

lgtm

@erikjohnston erikjohnston merged commit 6f5c6c8 into develop Oct 11, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4931 passed (1 hour, 20 minutes, 9 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 38 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 53 seconds)
Details
buildkite/synapse/isort Passed (24 seconds)
Details
buildkite/synapse/mypy Passed (50 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (22 seconds)
Details
buildkite/synapse/pipeline Passed (8 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (19 minutes, 42 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 37 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 4 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (19 minutes, 47 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 57 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (14 minutes, 45 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.