Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging config for the docker image #6197

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Oct 11, 2019

Turns out that loggers that are instantiated before the config is loaded get
turned off.

Also bring the logging config that is generated by --generate-config into line.

Fixes #6194.

@richvdh richvdh requested a review from matrix-org/synapse-core Oct 11, 2019
Turns out that loggers that are instantiated before the config is loaded get
turned off.

Also bring the logging config that is generated by --generate-config into line.

Fixes #6194.
@richvdh richvdh force-pushed the rav/fix_logging branch from ad48b0c to 08f5f23 Oct 11, 2019
Copy link
Member

erikjohnston left a comment

Otherwise LGTM

@@ -68,9 +68,6 @@
filters: [context]
loggers:
synapse:
level: INFO

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Oct 18, 2019

Member

Why remove this and not the synapse.storage.SQL below? It feels nice to give a place to easily up the synapse log level?

This comment has been minimized.

Copy link
@richvdh

richvdh Oct 18, 2019

Author Member

Do you think it's particularly likely that we would need to up the synapse log level and not other loggers? ie, why wouldn't you do this in the root logger?

The separate config for synapse.storage.SQL exists so that if you set your logging to DEBUG (either at the root level, or just for synapse), you don't start logging all the access tokens etc that go in and out of the database.

@richvdh richvdh merged commit 560c122 into develop Oct 18, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4941 passed (24 minutes, 18 seconds)
Details
buildkite/synapse/check-sample-config Passed (4 minutes, 18 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 43 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/mypy Passed (49 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (5 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 35 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 7 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 38 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 43 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 18 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 55 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (15 minutes, 43 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (14 minutes, 27 seconds)
Details
@richvdh richvdh deleted the rav/fix_logging branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.