Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix presence timeouts when synchrotron restarts. #6212

Merged
merged 3 commits into from Oct 18, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Oct 17, 2019

Handling timeouts would fail if there was an external process that had
timed out, e.g. a synchrotron restarting. This was due to a couple of
variable name typoes.

Fixes #3715.

Handling timeouts would fail if there was an external process that had
timed out, e.g. a synchrotron restarting. This was due to a couple of
variable name typoes.

Fixes #3715.
@erikjohnston erikjohnston force-pushed the erikj/fix_presence_timeouts branch from 88e48a5 to 1daed7f Oct 17, 2019
@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 17, 2019
Copy link
Member

richvdh left a comment

that was easier than I expected

@hawkowl hawkowl merged commit 5859a5c into develop Oct 18, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4966 passed (21 minutes, 8 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 23 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 51 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/mypy Passed (25 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pipeline Passed (9 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 10 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (5 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 55 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 5 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (14 minutes, 9 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 42 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 43 seconds)
Details
@hawkowl hawkowl deleted the erikj/fix_presence_timeouts branch Oct 18, 2019
@Dominik1999

This comment has been minimized.

Copy link

Dominik1999 commented Oct 18, 2019

Thank you so much, highly appreciated!

@Dominik1999

This comment has been minimized.

Copy link

Dominik1999 commented Oct 18, 2019

Do you include that into the 1.4.1 release?

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Oct 18, 2019

No, this will not be in the 1.4.1 release, which is just fixing a regression introduced in 1.4.0. We hope to release a 1.5.0 next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.