Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Auth.check method #6217

Merged
merged 2 commits into from Oct 18, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Oct 18, 2019

This method was somewhat redundant, and confusing.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file
  • Pull request includes a sign off
This method was somewhat redundant, and confusing.
@richvdh richvdh requested a review from matrix-org/synapse-core Oct 18, 2019
@richvdh richvdh added this to In progress in Homeserver Task Board via automation Oct 18, 2019
@richvdh richvdh moved this from In progress to Review in Homeserver Task Board Oct 18, 2019
changelog.d/6217.misc Outdated Show resolved Hide resolved
Co-Authored-By: Erik Johnston <erik@matrix.org>
@richvdh richvdh merged commit 93eaeec into develop Oct 18, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4987 passed (20 minutes, 55 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 28 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 43 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/mypy Passed (26 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 13 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 8 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 17 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 45 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (19 minutes)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 36 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (17 minutes, 17 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 52 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 31 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Oct 18, 2019
@richvdh richvdh deleted the rav/event_auth/2 branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.