Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upConvert EventContext to attrs #6218
Conversation
| self.prev_state_events = [] | ||
| self.rejected = False | ||
| self.app_service = None | ||
| state_group = attr.ib(default=None) |
This comment has been minimized.
This comment has been minimized.
hawkowl
Oct 19, 2019
Contributor
just a note: you can annotate the types in this with type= -- for the optional ones you want to use typing.Optional[int] or whatever. mypy can read that info, and also some editor IDEs can as well, so it can be worth it :)
This comment has been minimized.
This comment has been minimized.
|
On the old deps builders:
This is an 18.1.0 feature in attrs and we depend on a min of 17.4. We should probably upgrade to 18.1, or fix this here to use |
hawkowl
merged commit 9aee289
into
develop
18 checks passed
18 checks passed
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith
Passed (14 minutes, 25 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers
Passed (15 minutes, 48 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith
Passed (13 minutes, 56 seconds)
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
richvdh commentedOct 18, 2019
•
edited
The main driver for this was to get a sensible
__repr__, but the improved type-safety doesn't hurt.