Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete format_tap.py #6219

Merged
merged 2 commits into from Oct 19, 2019

Conversation

@anoadragon453
Copy link
Member

anoadragon453 commented Oct 18, 2019

We'd like to stop using the python implementation of format_tap for a perl one, such that any environment that's already set up to run Sytest (and thus perl) can run this script as well without having to set up a python environment.

This python implementation of a tap formatting library for buildkite has been
replaced with a perl implementation as part of the matrix-org/sytest repo,
which is specific to sytest's language, not that of any one homeserver's.

This is all for dendrite really.
@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Oct 18, 2019
@anoadragon453 anoadragon453 self-assigned this Oct 18, 2019
@anoadragon453 anoadragon453 added this to In progress in Homeserver Task Board via automation Oct 18, 2019
@anoadragon453 anoadragon453 moved this from In progress to Review in Homeserver Task Board Oct 18, 2019
Copy link
Contributor

hawkowl left a comment

yay less code (and yay less of my crappy code)

@hawkowl hawkowl merged commit 22a9f75 into develop Oct 19, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4994 passed (19 minutes, 52 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 56 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 28 seconds)
Details
buildkite/synapse/isort Passed (25 seconds)
Details
buildkite/synapse/mypy Passed (48 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (45 seconds)
Details
buildkite/synapse/packaging Passed (24 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 42 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 38 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 16 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (14 minutes, 8 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 20 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (14 minutes, 36 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.