Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo script on ipv6-supported boxes #6229

Merged
merged 2 commits into from Oct 22, 2019

Conversation

@anoadragon453
Copy link
Member

anoadragon453 commented Oct 21, 2019

The synapse demo was a bit flakey in terms of supporting federation. It turns out that if your computer resolved localhost to ::1 instead of 127.0.0.1, the built-in federation blacklist specified in start.sh would still block it, since it contained an entry for ::/127. Removing this no longer prevents Synapse from contacting ::1, federation works again on these boxes.

The synapse demo was a bit flakey in terms of supporting federation. It turns
out that if your computer resolved localhost to ::1 instead of 127.0.0.1, the
built-in federation blacklist specified in start.sh would still block it, since
it contained an entry for ::/127. Removing this no longer prevents Synapse from
contacting ::1, federation works again on these boxes.
@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Oct 21, 2019
@anoadragon453 anoadragon453 self-assigned this Oct 21, 2019
@anoadragon453 anoadragon453 added this to In progress in Homeserver Task Board via automation Oct 21, 2019
@anoadragon453 anoadragon453 moved this from In progress to Review in Homeserver Task Board Oct 21, 2019
Copy link
Member

richvdh left a comment

lgtm

@anoadragon453 anoadragon453 merged commit b2945d2 into develop Oct 22, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #5002 passed (21 minutes, 36 seconds)
Details
buildkite/synapse/check-sample-config Passed (2 minutes, 2 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 4 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (46 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (27 seconds)
Details
buildkite/synapse/pipeline Passed (9 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 1 second)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (16 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 3 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (16 minutes, 6 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (15 minutes, 8 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (12 minutes, 22 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Oct 22, 2019
@anoadragon453 anoadragon453 deleted the anoa/fix_demo_script_ipv6 branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.