Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for http proxies via http_proxy / HTTPS_PROXY env vars #6238

Closed
wants to merge 3 commits into from

Conversation

@richvdh
Copy link
Member

richvdh commented Oct 23, 2019

This PR implements support for routing outbound HTTP requests via a proxy.

The http_proxy and HTTPS_PROXY env vars can be set to a host[:port] value which should point to a proxy.

The address of the proxy should be excluded from IP blacklists such as the url_preview_ip_range_blacklist.

The proxy will then be used for

  • push
  • url previews
  • phone-home stats
  • recaptcha validation
  • CAS auth validation

It will not be used for:

  • Application Services
  • Identity servers
  • Outbound federation
  • In worker configurations, connections from workers to masters

Fixes #4198.

richvdh added 3 commits Oct 22, 2019
* fix some bugs on python 3
* better docstrings
* tests
@richvdh richvdh closed this Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.