Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete keys when deleting backup versions #6253

Merged
merged 5 commits into from Oct 25, 2019
Merged

Conversation

@uhoreg
Copy link
Member

uhoreg commented Oct 25, 2019

No description provided.

@uhoreg uhoreg requested a review from matrix-org/synapse-core Oct 25, 2019
uhoreg added 2 commits Oct 25, 2019
@uhoreg

This comment has been minimized.

Copy link
Member Author

uhoreg commented Oct 25, 2019

sytest failure is:

not ok 383 Gapped incremental syncs include all state changes

which seems unrelated to my changes

Copy link
Member

erikjohnston left a comment

LGTM other than tests

}


class E2eRoomKeysHandlerTestCase(unittest.TestCase):

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Oct 25, 2019

Member

Can you use HomeserverTestCase please? Its the new (ish) way of doing things such that we don't need to spin up a full reactor, and has a number of advantages.

Broadly, it works in the same way instead of doing @defer.inlineCallbacks and yield you can do self.get_success(self.store.some_deferred_returning_func())

uhoreg added 2 commits Oct 25, 2019
@uhoreg

This comment has been minimized.

Copy link
Member Author

uhoreg commented Oct 25, 2019

Given that I only made changes the unit test, and the sytest is now passing, it sounds like the "Gapped incremental syncs include all state changes" test is flaky.

@uhoreg uhoreg requested a review from erikjohnston Oct 25, 2019
@uhoreg uhoreg merged commit da78f61 into develop Oct 25, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #5134 passed (21 minutes, 34 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 56 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 37 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/mypy Passed (44 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (36 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 23 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 7 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (5 minutes, 55 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 6 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 57 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 46 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.