Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /keys/query API on workers. #6256

Merged
merged 2 commits into from Oct 25, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Oct 25, 2019

The necessary getters were added only to the master store and not the
worker stores.

The necessary getters were added only to the master store and not the
worker stores.
@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Oct 25, 2019

I think this was broke in #5769

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 25, 2019
Copy link
Member

richvdh left a comment

plausible

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Oct 25, 2019

shame this wasn't picked up in any tests

@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Oct 25, 2019

I'm updating the worker routes on sytest to match those in docs/workers.rs, which should hopefully pick this up

@erikjohnston erikjohnston merged commit 67290fa into release-v1.5.0 Oct 25, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #5128 passed (20 minutes, 1 second)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 33 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 33 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/mypy Passed (22 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (17 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 34 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (16 minutes, 15 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 2 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (12 minutes, 58 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (14 minutes, 42 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (12 minutes, 7 seconds)
Details
@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Oct 25, 2019

matrix-org/sytest#732 hopefully tests this

richvdh added a commit that referenced this pull request Oct 28, 2019
Synapse 1.5.0rc2 (2019-10-28)
=============================

Bugfixes
--------

- Update list of boolean columns in `synapse_port_db`. ([\#6247](#6247))
- Fix /keys/query API on workers. ([\#6256](#6256))
- Improve signature checking on some federation APIs. ([\#6262](#6262))

Internal Changes
----------------

- Move schema delta files to the correct data store. ([\#6248](#6248))
- Small performance improvement by removing repeated config lookups in room stats calculation. ([\#6255](#6255))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.