Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make room directory search case insensitive #6268

Merged
merged 4 commits into from Oct 29, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Oct 29, 2019

This doesn't use ILIKE because sqlite.

Fixes #6265

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 29, 2019
Copy link
Member

babolivier left a comment

lgtm otherwise

tox.ini Outdated
@@ -114,7 +114,7 @@ skip_install = True
basepython = python3.6
deps =
flake8
black
black==19.3b0

This comment has been minimized.

Copy link
@babolivier

babolivier Oct 29, 2019

Member

Can you add a comment that explains why we're pinning Black to this version?

@erikjohnston erikjohnston merged commit 1652c8c into release-v1.5.0 Oct 29, 2019
17 of 20 checks passed
17 of 20 checks passed
buildkite/synapse Build #5163 failed (33 minutes, 1 second)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Failed (exit status 127)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Failed (exit status 127)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 26 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 32 seconds)
Details
buildkite/synapse/isort Passed (18 seconds)
Details
buildkite/synapse/mypy Passed (27 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 32 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (5 minutes, 59 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 2 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (16 minutes, 12 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 20 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 42 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 44 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 12 seconds)
Details
@RichGriese

This comment has been minimized.

Copy link

RichGriese commented Oct 29, 2019

You folks are awesome. I just tested it on macOS desktop on the live riot/matrix.org site... and the search IS now case insensitive. Right on. Enjoy life... eat out more often!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.