Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to run isort on scripts and scripts-dev #6270

Merged
merged 4 commits into from Oct 30, 2019
Merged

Conversation

@anoadragon453
Copy link
Member

anoadragon453 commented Oct 29, 2019

We already run black and flake8 over the scripts and scripts-dev folders in CI:

synapse/tox.ini

Lines 119 to 120 in fa7cf87

python -m black --check --diff .
/bin/sh -c "flake8 synapse tests scripts scripts-dev scripts/hash_password scripts/register_new_matrix_user scripts/synapse_port_db synctl {env:PEP8SUFFIX:}"

Do the same with isort.

@anoadragon453 anoadragon453 self-assigned this Oct 29, 2019
@anoadragon453 anoadragon453 added this to In progress in Homeserver Task Board via automation Oct 29, 2019
@anoadragon453 anoadragon453 moved this from In progress to Review in Homeserver Task Board Oct 30, 2019
@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Oct 30, 2019
@anoadragon453 anoadragon453 merged commit 2cab02f into develop Oct 30, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5220 passed (21 minutes, 53 seconds)
Details
buildkite/synapse/check-sample-config Passed (2 minutes, 6 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 39 seconds)
Details
buildkite/synapse/isort Passed (21 seconds)
Details
buildkite/synapse/mypy Passed (44 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (17 seconds)
Details
buildkite/synapse/packaging Passed (19 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 12 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 17 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 37 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 40 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 22 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (2 minutes, 19 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 13 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 34 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (15 minutes, 32 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 38 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Oct 30, 2019
@anoadragon453 anoadragon453 deleted the anoa/ci_lint branch Oct 30, 2019
anoadragon453 added a commit that referenced this pull request Oct 30, 2019
…ger_warning

* 'develop' of github.com:matrix-org/synapse:
  Fix log line that was printing undefined value (#6278)
  Update CI to run isort on scripts and scripts-dev (#6270)
  Fix small typo in comment (#6269)
  Fix typo in domain name in account_threepid_delegates config option (#6273)
  Remove redundant arguments to CI's flake8 (#6277)
  Handle FileNotFound error in checking git repository version (#6284)
  Don't return coroutines
  Newsfile
  Port receipt and read markers to async/wait
  Make concurrently_execute work with async/await
  Newsfile
  Port federation_server to async/await
  Newsfile
  Port room rest handlers to async/await
  Newsfile
  Port replication http server endpoints to async/await
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.