Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd StateGroupStorage interface #6294
Merged
Conversation
|
lgtm. |
| @@ -147,6 +147,10 @@ def get_stream( | |||
|
|
|||
|
|
|||
| class EventHandler(BaseHandler): | |||
| def __init__(self, hs): | |||
| super(EventHandler, self).__init__(hs) | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Fix docstring Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
erikjohnston
merged commit dfe0cd7
into
develop
18 of 20 checks passed
18 of 20 checks passed
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5
Passed (1 minute, 25 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11
Passed (1 minute, 49 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith
Passed (15 minutes, 25 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers
Passed (14 minutes, 30 seconds)
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
erikjohnston commentedOct 30, 2019
•
edited
This currently just uses the existing
maindata store.Commits are independently reviewable.
(Split out from #6245.)