Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StateGroupStorage interface #6294

Merged
merged 4 commits into from Oct 31, 2019
Merged

Add StateGroupStorage interface #6294

merged 4 commits into from Oct 31, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Oct 30, 2019

This currently just uses the existing main data store.

Commits are independently reviewable.

(Split out from #6245.)

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 30, 2019
Copy link
Member

richvdh left a comment

lgtm.

synapse/storage/state.py Outdated Show resolved Hide resolved
@@ -147,6 +147,10 @@ def get_stream(


class EventHandler(BaseHandler):
def __init__(self, hs):
super(EventHandler, self).__init__(hs)

This comment has been minimized.

Copy link
@richvdh

richvdh Oct 31, 2019

Member

argless super() is a thing in py3 btw

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Oct 31, 2019

Author Member

Mind. Blown.

Fix docstring

Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@erikjohnston erikjohnston merged commit dfe0cd7 into develop Oct 31, 2019
18 of 20 checks passed
18 of 20 checks passed
buildkite/synapse Build #5304 failed (20 minutes, 3 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Failed (exit status 1)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 37 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 34 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (24 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 17 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 20 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 5 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 57 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 10 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 31 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 25 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 49 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 25 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (14 minutes, 30 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.