Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out an AsyncEventContext #6298

Merged
merged 6 commits into from Nov 1, 2019
Merged

Factor out an AsyncEventContext #6298

merged 6 commits into from Nov 1, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Oct 30, 2019

The intention here is to make it clearer which fields we can expect to be populated when: notably, that the _event_type etc aren't used for the synchronous impl of EventContext.

There is some preparatory work in getting rid of EventContext.update_state, which doesn't fit with this plan.

Commits should be independently reviewable.

@richvdh richvdh requested a review from matrix-org/synapse-core Oct 30, 2019
@richvdh richvdh added this to In progress in Homeserver Task Board via automation Oct 30, 2019
@richvdh richvdh moved this from In progress to Review in Homeserver Task Board Oct 30, 2019
@richvdh

This comment has been minimized.

Copy link
Member Author

richvdh commented Oct 30, 2019

(this is in prep for a fix to #6289)

@richvdh richvdh removed the request for review from matrix-org/synapse-core Oct 30, 2019
@richvdh richvdh force-pushed the rav/event_context/work branch 2 times, most recently from 8bb455a to 261240a Oct 30, 2019
richvdh added 4 commits Oct 30, 2019
The intention here is to make it clearer which fields we can expect to be
populated when: notably, that the _event_type etc aren't used for the
synchronous impl of EventContext.
@richvdh richvdh force-pushed the rav/event_context/work branch from 261240a to 560f33a Oct 30, 2019
@richvdh richvdh requested a review from matrix-org/synapse-core Oct 30, 2019
Copy link
Member

erikjohnston left a comment

Oth

synapse/events/snapshot.py Outdated Show resolved Hide resolved
@richvdh richvdh requested a review from erikjohnston Nov 1, 2019
to underline that it is an implementation detail
@richvdh richvdh merged commit c6516ad into develop Nov 1, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5357 passed (22 minutes, 44 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 55 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 40 seconds)
Details
buildkite/synapse/isort Passed (20 seconds)
Details
buildkite/synapse/mypy Passed (51 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (21 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 25 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 33 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 28 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 31 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 16 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 52 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 44 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (16 minutes, 59 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (14 minutes, 8 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (12 minutes, 20 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Nov 1, 2019
@richvdh richvdh deleted the rav/event_context/work branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.