Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MSC2326 (label based filtering) #6301

Merged
merged 16 commits into from Nov 1, 2019
Merged

Implement MSC2326 (label based filtering) #6301

merged 16 commits into from Nov 1, 2019

Conversation

@babolivier
Copy link
Member

babolivier commented Oct 30, 2019

Implements label-based filtering following MSC2326.

A future improvement would be to implement a background update to populate the event_labels table with data from past events; I plan to do so in a separate PR this is #6310.

Fixes #6288

babolivier added 8 commits Oct 29, 2019
@babolivier babolivier requested a review from matrix-org/synapse-core Oct 30, 2019
babolivier added 2 commits Oct 30, 2019
Copy link
Member

richvdh left a comment

a few nits about comments below about comments, but generally lgtm

changelog.d/6301.feature Outdated Show resolved Hide resolved
synapse/api/constants.py Outdated Show resolved Hide resolved
synapse/api/filtering.py Show resolved Hide resolved
synapse/storage/data_stores/main/events.py Outdated Show resolved Hide resolved
@richvdh richvdh removed their assignment Oct 31, 2019
@richvdh richvdh added this to In progress in Homeserver Task Board via automation Oct 31, 2019
@richvdh richvdh moved this from In progress to Review in Homeserver Task Board Oct 31, 2019
babolivier added 3 commits Nov 1, 2019
@babolivier babolivier requested a review from matrix-org/synapse-core Nov 1, 2019
@richvdh
richvdh approved these changes Nov 1, 2019
Copy link
Member

richvdh left a comment

lgtm otherwise

babolivier and others added 2 commits Nov 1, 2019
Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
@babolivier babolivier merged commit f496d25 into develop Nov 1, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5360 passed (33 minutes, 42 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 40 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 49 seconds)
Details
buildkite/synapse/isort Passed (31 seconds)
Details
buildkite/synapse/mypy Passed (39 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (18 seconds)
Details
buildkite/synapse/packaging Passed (34 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 54 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 38 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 17 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 34 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 42 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 49 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (2 minutes, 12 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (3 minutes, 3 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 19 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 28 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 22 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.