Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the REPLICATE command a bit better #6305

Merged
merged 6 commits into from Nov 4, 2019
Merged

document the REPLICATE command a bit better #6305

merged 6 commits into from Nov 4, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Oct 31, 2019

since I found myself wondering how it works

richvdh added 5 commits Oct 31, 2019
since I found myself wonder how it works
fix a circular reference with an abstract class, and s/dict/Dict/
@richvdh richvdh requested a review from matrix-org/synapse-core Nov 1, 2019
Returns:
Deferred|None
"""
raise NotImplementedError()

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Nov 1, 2019

Member

I'd be tempted to use abc

synapse/replication/tcp/client.py Show resolved Hide resolved
@richvdh richvdh merged commit cc6243b into develop Nov 4, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5356 passed (19 minutes, 54 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 30 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 51 seconds)
Details
buildkite/synapse/isort Passed (43 seconds)
Details
buildkite/synapse/mypy Passed (26 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (16 minutes, 40 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 38 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 22 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (16 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 59 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 9 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 15 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (16 minutes, 38 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (15 minutes, 40 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 48 seconds)
Details
@richvdh richvdh deleted the rav/repl_docs branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.