Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rstrip slashes from url on appservice #6306

Merged
merged 6 commits into from Oct 31, 2019

Conversation

@Half-Shot
Copy link
Contributor

Half-Shot commented Oct 31, 2019

On many occasions users have written registration files that contain an ending slash. Synapse already prefixes every request with a slash and this tends to trip up users more often than not. It seems wise here to just remove any trailing slashes on initiation.

And joy of joys, this fixes #3523

Half-Shot added 2 commits Oct 31, 2019
On many occasions users have written registration files that contain an ending slash. Synapse already prefixes every request with a slash and this tends to trip up users more often than not. It seems wise here to just remove any trailing slashes on initiation.
Copy link
Member

anoadragon453 left a comment

lgtm once CI is fixed

Half-Shot added 3 commits Oct 31, 2019
Copy link
Member

anoadragon453 left a comment

oh no I had opinions

synapse/appservice/__init__.py Outdated Show resolved Hide resolved
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Copy link
Member

anoadragon453 left a comment

LGTM!

@anoadragon453 anoadragon453 merged commit 42e707c into develop Oct 31, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5321 passed (21 minutes, 37 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 42 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 47 seconds)
Details
buildkite/synapse/isort Passed (18 seconds)
Details
buildkite/synapse/mypy Passed (24 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (19 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 57 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 23 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 10 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 48 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (19 minutes, 35 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (19 minutes, 30 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 31 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 13 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 14 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (12 minutes, 26 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 13 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 3 seconds)
Details
@anoadragon453 anoadragon453 deleted the hs/rstrip-as-url branch Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.