Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /purge_room admin API #6307

Merged
merged 3 commits into from Oct 31, 2019
Merged

Fix /purge_room admin API #6307

merged 3 commits into from Oct 31, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Oct 31, 2019

Presumably broken since #6115

It fails trying to clean the `topic` table which was recently removed.
@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 31, 2019
Copy link
Member

richvdh left a comment

lgtm

@erikjohnston erikjohnston merged commit 69489f8 into develop Oct 31, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5293 passed (19 minutes, 37 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 39 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 33 seconds)
Details
buildkite/synapse/isort Passed (28 seconds)
Details
buildkite/synapse/mypy Passed (24 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (14 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (16 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 30 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 8 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 49 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 33 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 36 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 52 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 10 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 46 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (15 minutes)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 10 seconds)
Details
@rubo77

This comment has been minimized.

Copy link
Contributor

rubo77 commented Nov 20, 2019

So what were the consequences of this bug?

Since what version was it introduced?

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Nov 21, 2019

So what were the consequences of this bug?

the purge_room api didn't work

Since what version was it introduced?

as per the description

@rubo77

This comment has been minimized.

Copy link
Contributor

rubo77 commented Nov 21, 2019

#6115 was merged 30.9.2019 in 16cb9a7 on develop and mergid into v1.5.0: https://github.com/matrix-org/synapse/releases/tag/v1.5.0

so if you are on 1.5.0 and need the purge-api, hurry up updating ;)

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Nov 21, 2019

to be clear, purge_room != purge_history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.