Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document lint.sh & allow application to specified files only #6312

Merged

Conversation

@neiljp
Copy link
Contributor

neiljp commented Oct 31, 2019

Thanks to @anoadragon453 for pointing me towards lint.sh 馃憤

So others can find it, this PR adds a note about it in the Code Style section of CONTRIBUTING.

Since the tool can take a while to run, I've amended it slightly to enable running it on specified files (if any arguments are provided), and adjusted the documentation added in the first commit accordingly. Now I can just run it on specific updated files, rather than it taking 4-5m here :)

Signed-off-by: neiljp (Neil Pilgrim) <github@kepier.clara.net>
@neiljp neiljp marked this pull request as ready for review Oct 31, 2019
Copy link
Member

anoadragon453 left a comment

LGTM otherwise!

CONTRIBUTING.rst Outdated Show resolved Hide resolved
scripts-dev/lint.sh Show resolved Hide resolved
neiljp added 2 commits Oct 31, 2019
Documentation updated to indicate this is possible.

Signed-off-by: neiljp (Neil Pilgrim) <github@kepier.clara.net>
Newsfile
Signed-off-by: neiljp (Neil Pilgrim) <github@kepier.clara.net>
@neiljp neiljp force-pushed the neiljp:2019-10-lint.sh-improvements branch from f737e08 to 1a97c9d Oct 31, 2019
@anoadragon453 anoadragon453 merged commit befd58f into matrix-org:develop Nov 1, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5327 passed (21 minutes, 33 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 26 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 6 seconds)
Details
buildkite/synapse/isort Passed (40 seconds)
Details
buildkite/synapse/mypy Passed (25 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (25 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 56 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 17 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 5 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 57 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 5 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 52 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 51 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (14 minutes, 44 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 52 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 19 seconds)
Details
@anoadragon453

This comment has been minimized.

Copy link
Member

anoadragon453 commented Nov 1, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.