Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hidden field in devices table for older sqlite #6313

Merged
merged 2 commits into from Nov 1, 2019

Conversation

@uhoreg
Copy link
Member

uhoreg commented Nov 1, 2019

fixes #6302

I've tested sqlite 3.27.2 (Debian buster) and sqlite 3.16.2 (Debian stretch), both doing upgrades of v1.4.1 -> v1.5.0 -> this branch, as well as v1.4.1 -> this branch. All the tests resulted in the correct behaviour of the hidden field set to 0 instead of 'FALSE'.

I was unable to figure out a way to avoid doing the db upgrade step from 56/hidden_devices.sql when going v1.4.1 -> this branch. Anything that I thought of would break something in sqlite and/or postgresql. So we're stuck with doing 56/hidden_devices.sql followed immediately by 56/hidden_devices_fix.sql.sqlite for sqlite database, which has to copy the whole devices table.

uhoreg added 2 commits Oct 31, 2019
@uhoreg uhoreg requested a review from matrix-org/synapse-core Nov 1, 2019
@richvdh
richvdh approved these changes Nov 1, 2019
Copy link
Member

richvdh left a comment

lgtm

@uhoreg uhoreg merged commit fa7e52c into develop Nov 1, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5332 passed (19 minutes, 16 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 25 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 58 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/mypy Passed (24 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (17 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (4 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 11 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 22 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 26 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 5 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (16 minutes, 48 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 49 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 40 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 13 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 21 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (14 minutes, 20 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 27 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.