Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add optional python dependencies to snap packaging #6317
Pull Request Checklist
This PR adds the optional dependencies to snapcraft packaging, including required build and stage libraries to enable features such as PostgreSQL support.
NOTE: This is currently done by adding the '.[all]' requirement to the python-packages section of the snapcraft file, to avoid having to keep the snapcraft file up to date as dependencies change, and also to work around al imitation in snapcraft, noted in LP#1786939. Once this bug is fixed, then the method could be changed to use a supported snapcraft option to pull in additional dependencies based on the
The additional stage and build packages are just used to ensure the required binary libraries which are needed by the optional dependencies are included in the resulting snap.
I have built and tested t his snap and am able to run a synapse instance using PostgreSQL as backing database based on these changes.
Signed-off-by: James Hebden firstname.lastname@example.org
anoadragon453 left a comment
This looks plausible. I don't think we need to pull in everything for postgres support, but as you say, it's mostly to not have the maintenance burden of a separate list of dependencies.
Very small change below, but otherwise looks good to me :) Thanks!