Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for EventContext fields #6319

Merged
merged 4 commits into from Nov 5, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Nov 4, 2019

No description provided.

@richvdh richvdh requested a review from matrix-org/synapse-core Nov 4, 2019
@richvdh richvdh force-pushed the rav/event_context/1 branch 2 times, most recently from 96f4455 to b70e641 Nov 4, 2019
@richvdh richvdh force-pushed the rav/event_context/1 branch from b70e641 to 069098d Nov 4, 2019
For a *rejected* state event, where the state of the rejected event is
ignored, this state_group should never make it into the
event_to_state_groups table. Indeed, inspecting this value for a rejected
state event is almost certainly incorrect.

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Nov 5, 2019

Member

(I wonder if we should make accessing state_group raise if its rejected)

This comment has been minimized.

Copy link
@richvdh

richvdh Nov 5, 2019

Author Member

yup could do!

This comment has been minimized.

Copy link
@richvdh

richvdh Nov 5, 2019

Author Member

well who knew, this identified a bug. I'm going to pull this out to a separate PR.

For an outlier, where we don't have the state at the event, this will be
None.
prev_group: If it is known, ``state_group``'s prev_group. Note that this being

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Nov 5, 2019

Member

Might be worth noting that this is not the state group associated with prev_state_ids

richvdh added 3 commits Nov 5, 2019
Per review comments: add some sanity checks on accessing state_group etc for
rejected events.
This reverts commit f84119b.

This turned out to identify some bugs, so I'm going to pull the whole lot out
to a separate PR.
@richvdh richvdh merged commit 4086002 into develop Nov 5, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5392 passed (22 minutes, 33 seconds)
Details
buildkite/synapse/check-sample-config Passed (2 minutes, 4 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 37 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/mypy Passed (49 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (41 seconds)
Details
buildkite/synapse/packaging Passed (39 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 38 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 13 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 43 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 8 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 37 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 57 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 55 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 52 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (17 minutes, 4 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (14 minutes, 30 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (14 minutes, 23 seconds)
Details
@richvdh richvdh deleted the rav/event_context/1 branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.