Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some checks that we aren't using state from rejected events #6330

Merged
merged 3 commits into from Nov 5, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Nov 5, 2019

Just to try to catch potential bugs earlier.

richvdh added 3 commits Nov 5, 2019
Per review comments: add some sanity checks on accessing state_group etc for
rejected events.
It didn't actually cause any bugs, because rejected events get filtered out at
various later points, but there's not point in trying to calculate the push
actions for a rejected event.
@richvdh richvdh requested a review from matrix-org/synapse-core Nov 5, 2019
Copy link
Member

erikjohnston left a comment

woo

@richvdh richvdh merged commit 0e3ab8a into develop Nov 5, 2019
20 checks passed
20 checks passed
buildkite/synapse Build #5400 passed (21 minutes, 22 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 50 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 50 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (24 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (19 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 51 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 5 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 38 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 35 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 35 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 1 second)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 59 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 43 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 42 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (16 minutes, 55 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 44 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (14 minutes, 42 seconds)
Details
@richvdh richvdh deleted the rav/event_context/3 branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.