Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement v2 APIs for send_join and send_leave #6349

Merged
merged 10 commits into from Dec 11, 2019
Merged

Conversation

@babolivier
Copy link
Member

babolivier commented Nov 11, 2019

Implements MSC1802.

Fix #6293

babolivier added 7 commits Nov 11, 2019
@babolivier babolivier marked this pull request as ready for review Nov 11, 2019
@babolivier babolivier requested a review from matrix-org/synapse-core Nov 11, 2019
babolivier added 2 commits Nov 11, 2019
@babolivier

This comment has been minimized.

Copy link
Member Author

babolivier commented Nov 14, 2019

SyTest tests will come later, in the meantime I suggest having a review on this one then holding off from merging until they're here.

Copy link
Member

erikjohnston left a comment

Modulo needing some tests

@babolivier

This comment has been minimized.

Copy link
Member Author

babolivier commented Dec 11, 2019

matrix-org/sytest#760 got approved, which tests one half of it. I'll merge both this PR and the SyTest one and work on the /send_leave tests as a next step.

@babolivier babolivier merged commit 54ae52b into develop Dec 11, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #5923 passed (22 minutes, 16 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 36 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 6 seconds)
Details
buildkite/synapse/isort Passed (18 seconds)
Details
buildkite/synapse/mypy Passed (20 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pipeline Passed (11 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 19 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (6 minutes, 21 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 47 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 38 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 51 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 41 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 17 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 4 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (10 minutes, 5 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (11 minutes, 32 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (12 minutes, 34 seconds)
Details
@babolivier babolivier deleted the babolivier/msc1802 branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.