/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Use topological orders for initial sync timeline #635

Merged
merged 3 commits into from Mar 11, 2016

Conversation

Reviewers
No reviews
Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Mar 9, 2016

This fixes the bug where if there are backfilled events included in an initial /sync response, the backfilled events are returned in reverse order.

erikjohnston added some commits Mar 9, 2016

@erikjohnston
Use topological orders for initial sync timeline

All checks have passed

4 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #95 origin/erikj/sync_order succeeded in 26 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #97 origin/erikj/sync_order succeeded in 4 min 50 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #99 origin/erikj/sync_order succeeded in 3 min 51 sec
Details
@matrixbot
Unit Tests (Commit) — Build #140 origin/erikj/sync_order succeeded in 1 min 6 sec
Details
3ecaabc
@erikjohnston
Return the correct token form

Some checks were not successful

1 failing and 3 successful checks
@matrixbot
Sytest SQLite (Commit) — Build #100 origin/erikj/sync_order found unstable in 23 sec
Details
@matrixbot
Flake8 + Packaging (Commit) — Build #96 origin/erikj/sync_order succeeded in 28 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #98 origin/erikj/sync_order succeeded in 4 min 32 sec
Details
@matrixbot
Unit Tests (Commit) — Build #141 origin/erikj/sync_order succeeded in 1 min 9 sec
Details
af2fe61
@erikjohnston
Add comment

All checks have passed

8 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #97 origin/erikj/sync_order succeeded in 29 sec
Details
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #100 origin/erikj/sync_order succeeded in 5 min 24 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #101 origin/erikj/sync_order succeeded in 4 min 11 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Commit) — Build #142 origin/erikj/sync_order succeeded in 1 min 6 sec
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
8a88684

@erikjohnston erikjohnston assigned NegativeMjark Mar 9, 2016

@erikjohnston
Owner

erikjohnston commented Mar 9, 2016

@matrixbot retest this please
@erikjohnston
Owner

erikjohnston commented Mar 9, 2016

@matrixbot retest this please
@erikjohnston
Owner

erikjohnston commented Mar 10, 2016

The Sytest Postgres (Commit) was a flakey sytest which has now been fixed.
@NegativeMjark
Contributor

NegativeMjark commented Mar 11, 2016

LGTM

erikjohnston added a commit that referenced this pull request Mar 11, 2016

@erikjohnston
Merge pull request #635 from matrix-org/erikj/sync_order 
Use topological orders for initial sync timeline

All checks have passed

4 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #107 origin/develop succeeded in 29 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #110 origin/develop succeeded in 5 min 9 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #111 origin/develop succeeded in 3 min 51 sec
Details
@matrixbot
Unit Tests (Commit) — Build #152 origin/develop succeeded in 1 min 0 sec
Details
58443a0

@erikjohnston erikjohnston merged commit 58443a0 into develop Mar 11, 2016
8 checks passed

8 checks passed

Flake8 + Packaging (Commit) Build #97 origin/erikj/sync_order succeeded in 29 sec
Details
Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #100 origin/erikj/sync_order succeeded in 5 min 24 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #101 origin/erikj/sync_order succeeded in 4 min 11 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Commit) Build #142 origin/erikj/sync_order succeeded in 1 min 6 sec
Details
Unit Tests (Merged PR) Build finished.
Details

@richvdh richvdh deleted the erikj/sync_order branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment