/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SYN-646 - Register endpoint returns refresh_token #637

Merged
merged 2 commits into from Mar 10, 2016

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@blide @matrixbot @erikjohnston
@blide
Contributor

blide commented Mar 10, 2016

Guest registration still doesn't return refresh_token
@blide
Register endpoint returns refresh_token 
Guest registration still doesn't return refresh_token

Some checks were not successful

1 failing and 3 successful checks
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
40160e2
@matrixbot

matrixbot commented Mar 10, 2016

Can one of the admins verify this patch?
@matrixbot

matrixbot commented Mar 10, 2016

Can one of the admins verify this patch?
@matrixbot

matrixbot commented Mar 10, 2016

Can one of the admins verify this patch?
@matrixbot

matrixbot commented Mar 10, 2016

Can one of the admins verify this patch?
@erikjohnston
Owner

erikjohnston commented Mar 10, 2016

@matrixbot ok to test
@erikjohnston
Owner

erikjohnston commented Mar 10, 2016

The flake8 test failed due to: http://matrix.org/jenkins/job/SynapseFlake8Packaging/51/violations/file/tests/rest/client/v2_alpha/test_register.py/

@erikjohnston erikjohnston self-assigned this Mar 10, 2016

@blide
Flake8 fix

All checks have passed

4 successful checks
@matrixbot
Flake8 + Packaging (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
@matrixbot
Unit Tests (Merged PR) — Build finished.
Details
1be438f
@blide
Contributor

blide commented Mar 10, 2016

Fixed
@erikjohnston
Owner

erikjohnston commented Mar 10, 2016

Brilliant, thanks for this! Could you just follow the sign off steps: https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off? Just commenting with "Signed-off-by: Your Name <your@email.example.org>" here is fine.
@erikjohnston
Owner

erikjohnston commented Mar 10, 2016

Also feel free to add yourself to AUTHORS.rst :)
@blide
Contributor

blide commented Mar 10, 2016

Thanks for a good project.
Signed-off-by: Roman Shakhov r.intval@gmail.com

erikjohnston added a commit that referenced this pull request Mar 10, 2016

@erikjohnston
Merge pull request #637 from blide/develop 
SYN-646 - Register endpoint returns refresh_token

All checks have passed

4 successful checks
@matrixbot
Flake8 + Packaging (Commit) — Build #98 origin/develop succeeded in 30 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #101 origin/develop succeeded in 5 min 14 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #102 origin/develop succeeded in 4 min 20 sec
Details
@matrixbot
Unit Tests (Commit) — Build #143 origin/develop succeeded in 1 min 11 sec
Details
c22a3f3

@erikjohnston erikjohnston merged commit c22a3f3 into matrix-org:develop Mar 10, 2016
4 checks passed

4 checks passed

Flake8 + Packaging (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
Unit Tests (Merged PR) Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment