Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Change permissions for data dir before attempting to write to it #6389

Merged
merged 2 commits into from Nov 20, 2019

Conversation

@anoadragon453
Copy link
Member

anoadragon453 commented Nov 20, 2019

Fixes: #6303

Context: #6303 (comment)

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Nov 20, 2019
@anoadragon453 anoadragon453 self-assigned this Nov 20, 2019
@anoadragon453 anoadragon453 added this to In progress in Homeserver Task Board via automation Nov 20, 2019
@anoadragon453 anoadragon453 moved this from In progress to Review in Homeserver Task Board Nov 20, 2019
Copy link
Member

babolivier left a comment

Looks sane to me, I assume you've tested it locally as well. Let's merge it once the CI is happy.

@anoadragon453 anoadragon453 merged commit 234f55f into develop Nov 20, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #5576 passed (22 minutes, 15 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 40 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 11 seconds)
Details
buildkite/synapse/isort Passed (18 seconds)
Details
buildkite/synapse/mypy Passed (26 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (22 seconds)
Details
buildkite/synapse/pipeline Passed (10 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 17 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 37 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (9 minutes, 16 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 17 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 20 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 31 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 18 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 48 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 47 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 30 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (15 minutes, 28 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (13 minutes, 51 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (13 minutes, 45 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (11 minutes, 56 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Nov 20, 2019
@anoadragon453 anoadragon453 deleted the anoa/docker_fix branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.