Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically delete empty groups/communities #6453

Merged
merged 3 commits into from Dec 16, 2019

Conversation

@Matombo
Copy link
Contributor

Matombo commented Dec 3, 2019

Signed-off-by: Werner Sembach werner.sembach@fau.de

Another approach to #3023 than #3401.

These changes automatically delete a group/community as soon as the last member leaves the group. The commit also include a sql delta to delete all current empty groups in the database.

Matombo added 2 commits Dec 3, 2019
Signed-off-by: Werner Sembach <werner.sembach@fau.de>
Signed-off-by: Werner Sembach <werner.sembach@fau.de>
@richvdh richvdh added this to In progress in Homeserver Task Board via automation Dec 4, 2019
@richvdh richvdh moved this from In progress to Community PRs in Homeserver Task Board Dec 5, 2019
Copy link
Member

anoadragon453 left a comment

Tested and works. LGTM otherwise.

@anoadragon453 anoadragon453 self-assigned this Dec 11, 2019
@Matombo

This comment has been minimized.

Copy link
Contributor Author

Matombo commented Dec 11, 2019

Nice, fixed the 2 errors in the comments

@Matombo Matombo requested a review from anoadragon453 Dec 11, 2019
@anoadragon453

This comment has been minimized.

Copy link
Member

anoadragon453 commented Dec 16, 2019

Wonderful, thank you!

@anoadragon453 anoadragon453 merged commit 9d173b3 into matrix-org:develop Dec 16, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6085 passed (22 minutes, 4 seconds)
Details
buildkite/synapse/check-sample-config Passed (2 minutes)
Details
buildkite/synapse/check-style Passed (1 minute, 49 seconds)
Details
buildkite/synapse/isort Passed (41 seconds)
Details
buildkite/synapse/mypy Passed (50 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (42 seconds)
Details
buildkite/synapse/packaging Passed (41 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 49 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 27 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (17 minutes, 50 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (17 minutes, 48 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 42 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 48 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 51 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (12 minutes, 30 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (11 minutes, 59 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (10 minutes, 28 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (10 minutes, 14 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (12 minutes, 19 seconds)
Details
Homeserver Task Board automation moved this from Community PRs to Done Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.