Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port handlers.account_validity to async/await. #6504

Merged
merged 3 commits into from Dec 11, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Dec 10, 2019

No description provided.

@erikjohnston erikjohnston force-pushed the erikj/account_validity_async_await branch from 9295909 to 3f97b4c Dec 10, 2019
@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Dec 10, 2019
Copy link
Member

richvdh left a comment

lgtm

@@ -54,6 +51,5 @@ def get_new_events(self, user, from_key, **kwargs):

return results, current_stream_id

@defer.inlineCallbacks
def get_pagination_rows(self, user, config, key):
async def get_pagination_rows(self, user, config, key):

This comment has been minimized.

Copy link
@richvdh

richvdh Dec 11, 2019

Member

is this even used?

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Dec 11, 2019

Author Member

You raise a good point, seems like only /initialSync uses it for presence and receipts. Given it's kind of part of the *EventSource API I'll leave it to another PR to remove it from everywhere.

@erikjohnston erikjohnston merged commit 31905a5 into develop Dec 11, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6051 passed (29 minutes, 27 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 26 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 51 seconds)
Details
buildkite/synapse/isort Passed (18 seconds)
Details
buildkite/synapse/mypy Passed (51 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (15 seconds)
Details
buildkite/synapse/packaging Passed (18 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 24 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 58 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (7 minutes, 29 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 20 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 52 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 31 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 17 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 12 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 8 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (12 minutes, 36 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (10 minutes, 32 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (12 minutes, 46 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (11 minutes, 14 seconds)
Details
@erikjohnston erikjohnston deleted the erikj/account_validity_async_await branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.