Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SnapshotCache in favour of ResponseCache #6506

Merged
merged 2 commits into from Dec 10, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Dec 10, 2019

The only functional change here is to make the cache of /initialSync to expire immediately rather than after 5 minutes, bringing it in line with /sync. We can add timeout_ms=5 * 60 * 1000 if we want to bring them into line

erikjohnston added 2 commits Dec 9, 2019
@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Dec 10, 2019
Copy link
Member

richvdh left a comment

I think the timeout is important, but 🤷‍♂

lgtm otherwise

@erikjohnston

This comment has been minimized.

Copy link
Member Author

erikjohnston commented Dec 10, 2019

Nothing should use global /initialSync anymore and its basically equivalent to doing an initial sync which doesn't have a timeout, so 🤷‍♂

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Dec 10, 2019

OHHH

@erikjohnston erikjohnston merged commit e3f528c into develop Dec 10, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6024 passed (23 minutes, 18 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 34 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 4 seconds)
Details
buildkite/synapse/isort Passed (16 seconds)
Details
buildkite/synapse/mypy Passed (25 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (16 seconds)
Details
buildkite/synapse/packaging Passed (19 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (18 minutes, 25 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 41 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 28 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 40 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (19 minutes, 23 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (18 minutes, 6 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 27 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 26 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 14 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (13 minutes, 11 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (13 minutes, 23 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (10 minutes, 46 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (11 minutes, 15 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (13 minutes, 19 seconds)
Details
@erikjohnston erikjohnston deleted the erikj/remove_snapshot_cache branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.