Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move database config from apps into HomeServer object #6511

Merged
merged 4 commits into from Dec 12, 2019

Conversation

@erikjohnston
Copy link
Member

erikjohnston commented Dec 10, 2019

No description provided.

@erikjohnston erikjohnston force-pushed the erikj/remove_db_config_from_apps branch 3 times, most recently from 951685c to 3af3f91 Dec 10, 2019
@erikjohnston erikjohnston force-pushed the erikj/remove_db_config_from_apps branch from 3af3f91 to d630c82 Dec 10, 2019
@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Dec 10, 2019
synapse/server.py Outdated Show resolved Hide resolved
Copy link
Member

richvdh left a comment

lgtm otherwise. yay less duplication.

@erikjohnston erikjohnston merged commit b8e4b39 into develop Dec 12, 2019
22 checks passed
22 checks passed
buildkite/synapse Build #6104 passed (23 minutes, 1 second)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 22 seconds)
Details
buildkite/synapse/check-style Passed (2 minutes, 6 seconds)
Details
buildkite/synapse/isort Passed (45 seconds)
Details
buildkite/synapse/mypy Passed (45 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (13 seconds)
Details
buildkite/synapse/packaging Passed (16 seconds)
Details
buildkite/synapse/pipeline Passed (4 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (17 minutes, 39 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 43 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (19 minutes, 29 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (19 minutes, 2 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (6 minutes, 30 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-5-slash-postgres-9-dot-5 Passed (1 minute, 28 seconds)
Details
buildkite/synapse/synapse-port-db-slash-python-3-dot-7-slash-postgres-11 Passed (1 minute, 6 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (18 minutes, 43 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (19 minutes, 13 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (9 minutes, 25 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-monolith Passed (15 minutes, 48 seconds)
Details
buildkite/synapse/sytest-python-3-dot-7-slash-postgres-11-slash-workers Passed (13 minutes, 35 seconds)
Details
@erikjohnston erikjohnston deleted the erikj/remove_db_config_from_apps branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.